Remove dead-code

internal/datasets/subjectsetbytype.go

@@ -89,11 +89,6 @@ func (s *SubjectByTypeSet) IsEmpty() bool {
 	return len(s.byType) == 0
 }
 
-// Len returns the number of keys in the set.
-func (s *SubjectByTypeSet) Len() int {
-	return len(s.byType)
-}
-
 // SubjectSetForType returns the subject set associated with the given subject type, if any.
 func (s *SubjectByTypeSet) SubjectSetForType(rr *core.RelationReference) (SubjectSet, bool) {
 	found, ok := s.byType[tuple.JoinRelRef(rr.Namespace, rr.Relation)]

internal/datastore/crdb/options.go

@@ -321,15 +321,6 @@ func WithEnableConnectionBalancing(connectionBalancing bool) Option {
 	return func(po *crdbOptions) { po.enableConnectionBalancing = connectionBalancing }
 }
 
-// DebugAnalyzeBeforeStatistics signals to the Statistics method that it should
-// run Analyze on the database before returning statistics. This should only be
-// used for debug and testing.
-//
-// Disabled by default.
-func DebugAnalyzeBeforeStatistics() Option {
-	return func(po *crdbOptions) { po.analyzeBeforeStatistics = true }
-}
-
 // FilterMaximumIDCount is the maximum number of IDs that can be used to filter IDs in queries
 func FilterMaximumIDCount(filterMaximumIDCount uint16) Option {
 	return func(po *crdbOptions) { po.filterMaximumIDCount = filterMaximumIDCount }

internal/datastore/mysql/options.go

@@ -210,17 +210,6 @@ func MaxOpenConns(conns int) Option {
 	}
 }
 
-// DebugAnalyzeBeforeStatistics signals to the Statistics method that it should
-// run Analyze Table on the relationships table before returning statistics.
-// This should only be used for debug and testing.
-//
-// Disabled by default.
-func DebugAnalyzeBeforeStatistics() Option {
-	return func(mo *mysqlOptions) {
-		mo.analyzeBeforeStats = true
-	}
-}
-
 // OverrideLockWaitTimeout sets the lock wait timeout on each new connection established
 // with the databases. As an OLTP service, the default of 50s is unbearably long to block
 // a write for our service, so we suggest setting this value to the minimum of 1 second.

internal/datastore/postgres/common/pgx.go

@@ -162,16 +162,6 @@ func ParseConfigWithInstrumentation(url string) (*pgx.ConnConfig, error) {
 	return connConfig, nil
 }
 
-// ConnectWithInstrumentation returns a pgx.Conn that has been instrumented for observability
-func ConnectWithInstrumentation(ctx context.Context, url string) (*pgx.Conn, error) {
-	connConfig, err := ParseConfigWithInstrumentation(url)
-	if err != nil {
-		return nil, err
-	}
-
-	return pgx.ConnectConfig(ctx, connConfig)
-}
-
 // ConnectWithInstrumentationAndTimeout returns a pgx.Conn that has been instrumented for observability
 func ConnectWithInstrumentationAndTimeout(ctx context.Context, url string, connectTimeout time.Duration) (*pgx.Conn, error) {
 	connConfig, err := ParseConfigWithInstrumentation(url)

internal/datastore/postgres/log_tracer.go

@@ -1,16 +1,3 @@
 package postgres
 
-import (
-	"context"
-
-	"github.com/jackc/pgx/v5/tracelog"
-	"go.opentelemetry.io/otel/attribute"
-	"go.opentelemetry.io/otel/trace"
-)
-
 type tracingLogger struct{}
-
-func (tl tracingLogger) Log(ctx context.Context, level tracelog.LogLevel, msg string, _ map[string]interface{}) {
-	span := trace.SpanFromContext(ctx)
-	span.AddEvent(msg, trace.WithAttributes(attribute.Stringer("level", level), attribute.String("datastore", "postgres")))
-}

internal/datastore/postgres/options.go

@@ -333,24 +333,6 @@ func GCEnabled(isGCEnabled bool) Option {
 	return func(po *postgresOptions) { po.gcEnabled = isGCEnabled }
 }
 
-// DebugAnalyzeBeforeStatistics signals to the Statistics method that it should
-// run Analyze on the database before returning statistics. This should only be
-// used for debug and testing.
-//
-// Disabled by default.
-func DebugAnalyzeBeforeStatistics() Option {
-	return func(po *postgresOptions) { po.analyzeBeforeStatistics = true }
-}
-
-// WithQueryInterceptor adds an interceptor to all underlying postgres queries
-//
-// By default, no query interceptor is used.
-func WithQueryInterceptor(interceptor pgxcommon.QueryInterceptor) Option {
-	return func(po *postgresOptions) {
-		po.queryInterceptor = interceptor
-	}
-}
-
 // MigrationPhase configures the postgres driver to the proper state of a
 // multi-phase migration.
 //

internal/developmentmembership/trackingsubjectset.go

@@ -55,13 +55,6 @@ func (tss *TrackingSubjectSet) MustAddFrom(otherSet *TrackingSubjectSet) {
 	}
 }
 
-// RemoveFrom removes any subjects found in the other set from this set.
-func (tss *TrackingSubjectSet) RemoveFrom(otherSet *TrackingSubjectSet) {
-	for key, oss := range otherSet.setByType {
-		tss.getSetForKey(key).SubtractAll(oss)
-	}
-}
-
 // MustAdd adds the given subjects to this set.
 func (tss *TrackingSubjectSet) MustAdd(subjectsAndResources ...FoundSubject) {
 	err := tss.Add(subjectsAndResources...)

internal/dispatch/combined/combined.go

@@ -124,14 +124,6 @@ func DispatchChunkSize(dispatchChunkSize uint16) Option {
 	}
 }
 
-// RemoteDispatchTimeout sets the maximum timeout for a remote dispatch.
-// Defaults to 60s (as defined in the remote dispatcher).
-func RemoteDispatchTimeout(remoteDispatchTimeout time.Duration) Option {
-	return func(state *optionState) {
-		state.remoteDispatchTimeout = remoteDispatchTimeout
-	}
-}
-
 // NewDispatcher initializes a Dispatcher that caches and redispatches
 // optionally to the provided upstream.
 func NewDispatcher(options ...Option) (dispatch.Dispatcher, error) {

internal/graph/errors.go

@@ -1,7 +1,6 @@
 package graph
 
 import (
-	"errors"
 	"fmt"
 
 	"github.com/rs/zerolog"
@@ -55,13 +54,6 @@ type AlwaysFailError struct {
 	error
 }
 
-// NewAlwaysFailErr constructs a new always fail error.
-func NewAlwaysFailErr() error {
-	return AlwaysFailError{
-		error: errors.New("always fail"),
-	}
-}
-
 // RelationNotFoundError occurs when a relation was not found under a namespace.
 type RelationNotFoundError struct {
 	error
@@ -79,27 +71,6 @@ func (err RelationNotFoundError) NotFoundRelationName() string {
 	return err.relationName
 }
 
-func (err RelationNotFoundError) MarshalZerologObject(e *zerolog.Event) {
-	e.Err(err.error).Str("namespace", err.namespaceName).Str("relation", err.relationName)
-}
-
-// DetailsMetadata returns the metadata for details for this error.
-func (err RelationNotFoundError) DetailsMetadata() map[string]string {
-	return map[string]string{
-		"definition_name":             err.namespaceName,
-		"relation_or_permission_name": err.relationName,
-	}
-}
-
-// NewRelationNotFoundErr constructs a new relation not found error.
-func NewRelationNotFoundErr(nsName string, relationName string) error {
-	return RelationNotFoundError{
-		error:         fmt.Errorf("relation/permission `%s` not found under definition `%s`", relationName, nsName),
-		namespaceName: nsName,
-		relationName:  relationName,
-	}
-}
-
 var _ sharederrors.UnknownRelationError = RelationNotFoundError{}
 
 // RelationMissingTypeInfoError defines an error for when type information is missing from a relation
@@ -132,15 +103,6 @@ func (err RelationMissingTypeInfoError) DetailsMetadata() map[string]string {
 	}
 }
 
-// NewRelationMissingTypeInfoErr constructs a new relation not missing type information error.
-func NewRelationMissingTypeInfoErr(nsName string, relationName string) error {
-	return RelationMissingTypeInfoError{
-		error:         fmt.Errorf("relation/permission `%s` under definition `%s` is missing type information", relationName, nsName),
-		namespaceName: nsName,
-		relationName:  relationName,
-	}
-}
-
 // WildcardNotAllowedError occurs when a request sent has an invalid wildcard argument.
 type WildcardNotAllowedError struct {
 	error
@@ -175,13 +137,6 @@ type UnimplementedError struct {
 	error
 }
 
-// NewUnimplementedErr constructs a new unimplemented error.
-func NewUnimplementedErr(baseErr error) error {
-	return UnimplementedError{
-		error: baseErr,
-	}
-}
-
 func (e UnimplementedError) Unwrap() error {
 	return e.error
 }

internal/graph/graph.go

@@ -27,18 +27,9 @@ type ExpandResult struct {
 	Err  error
 }
 
-func (er ExpandResult) ResultError() error {
-	return er.Err
-}
-
 // ReduceableExpandFunc is a function that can be bound to a execution context.
 type ReduceableExpandFunc func(ctx context.Context, resultChan chan<- ExpandResult)
 
-// AlwaysFailExpand is a ReduceableExpandFunc which will always fail when reduced.
-func AlwaysFailExpand(_ context.Context, resultChan chan<- ExpandResult) {
-	resultChan <- expandResultError(NewAlwaysFailErr(), emptyMetadata)
-}
-
 // ExpandReducer is a type for the functions Any and All which combine check results.
 type ExpandReducer func(
 	ctx context.Context,

internal/logging/logger.go

@@ -2,7 +2,6 @@ package logging
 
 import (
 	"context"
-	"fmt"
 
 	"github.com/rs/zerolog"
 )
@@ -36,14 +35,4 @@ func Fatal() *zerolog.Event { return Logger.Fatal() }
 
 func WithLevel(level zerolog.Level) *zerolog.Event { return Logger.WithLevel(level) }
 
-func Log() *zerolog.Event { return Logger.Log() }
-
 func Ctx(ctx context.Context) *zerolog.Logger { return zerolog.Ctx(ctx) }
-
-func Print(v ...interface{}) {
-	Logger.Debug().CallerSkipFrame(1).Msg(fmt.Sprint(v...))
-}
-
-func Printf(format string, v ...interface{}) {
-	Logger.Debug().CallerSkipFrame(1).Msgf(format, v...)
-}

internal/middleware/dispatcher/dispatcher.go

@@ -33,17 +33,6 @@ func FromContext(ctx context.Context) dispatch.Dispatcher {
 	return nil
 }
 
-// MustFromContext reads the selected dispatcher out of a context.Context, computes a zedtoken
-// from it, and panics if it has not been set on the context.
-func MustFromContext(ctx context.Context) dispatch.Dispatcher {
-	dispatcher := FromContext(ctx)
-	if dispatcher == nil {
-		panic("dispatcher middleware did not inject dispatcher")
-	}
-
-	return dispatcher
-}
-
 // SetInContext adds a dispatcher to the given context
 func SetInContext(ctx context.Context, dispatcher dispatch.Dispatcher) error {
 	handle := ctx.Value(dispatcherKey)

internal/services/v0/developer.go

@@ -6,7 +6,6 @@ import (
 
 	v0 "github.com/authzed/authzed-go/proto/authzed/api/v0"
 	"github.com/authzed/grpcutil"
-	"google.golang.org/grpc"
 	"google.golang.org/protobuf/encoding/prototext"
 
 	log "github.com/authzed/spicedb/internal/logging"
@@ -21,13 +20,6 @@ type devServer struct {
 	shareStore ShareStore
 }
 
-// RegisterDeveloperServer adds the Developer Server to a grpc service registrar
-// This is preferred over manually registering the service; it will add required middleware
-func RegisterDeveloperServer(r grpc.ServiceRegistrar, s v0.DeveloperServiceServer) *grpc.ServiceDesc {
-	r.RegisterService(grpcutil.WrapMethods(v0.DeveloperService_ServiceDesc, grpcutil.DefaultUnaryMiddleware...), s)
-	return &v0.DeveloperService_ServiceDesc
-}
-
 // NewDeveloperServer creates an instance of the developer server.
 func NewDeveloperServer(store ShareStore) v0.DeveloperServiceServer {
 	return &devServer{

internal/testfixtures/generator.go

@@ -2,7 +2,6 @@ package testfixtures
 
 import (
 	"context"
-	"math/rand"
 	"strconv"
 	"testing"
 
@@ -15,21 +14,6 @@ const (
 	SubsequentLetters = FirstLetters + "/_|-"
 )
 
-func RandomObjectID(length uint8) string {
-	b := make([]byte, length)
-	for i := range b {
-		sourceLetters := SubsequentLetters
-		if i == 0 {
-			sourceLetters = FirstLetters
-		}
-		// nolint:gosec
-		// G404 use of non cryptographically secure random number generator is not a security concern here,
-		// as this is only used for generating fixtures in testing.
-		b[i] = sourceLetters[rand.Intn(len(sourceLetters))]
-	}
-	return string(b)
-}
-
 func NewBulkRelationshipGenerator(objectType, relation, subjectType string, count int, t *testing.T) *BulkRelationshipGenerator {
 	return &BulkRelationshipGenerator{
 		count,