[WIP] Support add/remove dependency to the given project #318
Conversation
| if cmd.project.is_some() && pyproject_toml.is_workspace_root() { | ||
| let workspace = pyproject_toml.workspace().unwrap(); | ||
| pyproject_toml = workspace.get_project(&cmd.project.unwrap())?.unwrap(); | ||
| } | ||
| let py_ver = match pyproject_toml.target_python_version() { | ||
| Some(ver) => ver.format_simple(), | ||
| None => "".to_string(), |
There was a problem hiding this comment.
Because I looked at it before for the --pyproject arg work:
Inside the requirement code in this same file, apply_to_requirement there is some logic about relative paths for path dependencies. That code uses the current working directory path as starting point. We might need to think about how that one should work together with this feature.
There was a problem hiding this comment.
The current messy way of adding local dependency is rooted in the limited support of pip-tools. I am looking for a proper way to make relative paths work properly. The main issue is that after adding dependencies for a specific project, lock and sync will fail due to the inability to find the path.
There was a problem hiding this comment.
I just saw this PR #321, 👍
rye/src/cli/add.rs
Outdated
| let mut pyproject_toml = PyProject::discover()?; | ||
| if cmd.project.is_some() && pyproject_toml.is_workspace_root() { | ||
| let workspace = pyproject_toml.workspace().unwrap(); | ||
| pyproject_toml = workspace.get_project(&cmd.project.unwrap())?.unwrap(); |
There was a problem hiding this comment.
It's possible to write this using if let or match to avoid all or most of the unwraps. if let Some(project) = cmd.project etc avoids one, for example.
ischaojie
changed the title
ischaojie
changed the title
|
Since there are still many problems with adding local dependencies, I'll close this PR for now. |
[WIP]