Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[airflow]: extend removed args (AIR302) #14765

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Dec 4, 2024

Summary

Airflow 3.0 removes various deprecated functions, members, modules, and other values. They have been deprecated in 2.x, but the removal causes incompatibilities that we want to detect. This PR deprecates the following names.

  • in DAG
    • sla_miss_callback was removed
  • in airflow.operators.trigger_dagrun.TriggerDagRunOperator
    • execution_date was removed
  • in airflow.operators.weekday.DayOfWeekSensor, airflow.operators.datetime.BranchDateTimeOperator and airflow.operators.weekday.BranchDayOfWeekOperator
    • use_task_execution_day was removed in favor of use_task_logical_date

The full list of rules we will extend apache/airflow#44556

Test Plan

A test fixture is included in the PR.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@Lee-W Lee-W changed the title feat(AIR302): extend removed args [airflow]: extend removed args (AIR302) Dec 4, 2024
@Lee-W Lee-W force-pushed the extend-removed-args branch from fee49c1 to 651c37a Compare December 4, 2024 11:13
@Lee-W Lee-W marked this pull request as ready for review December 4, 2024 14:43
@Lee-W
Copy link
Contributor Author

Lee-W commented Dec 6, 2024

@MichaReiser would be nice if you could also take a look at this one when you have some time 🙂 many thanks! 🙏

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I must have missed this PR. Thanks for the ping. This looks good.

@MichaReiser MichaReiser added rule Implementing or modifying a lint rule preview Related to preview mode features labels Dec 6, 2024
@MichaReiser MichaReiser merged commit 3ea14d7 into astral-sh:main Dec 6, 2024
21 checks passed
@Lee-W
Copy link
Contributor Author

Lee-W commented Dec 7, 2024

Thanks for your immediate help 🙏

@Lee-W Lee-W deleted the extend-removed-args branch December 18, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants