Fix compatibility with Argo Workflows 3.6 #1293
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
pod_gc
onWorkflowTemplate
is not rendered correctly) #1292Description of PR
Updates auto-generated models to Argo 3.6. Note there are a few changes to Hera code which are technically breaking changes (but are very simple for users to change):
resources: Optional[ResourceRequirements]
is nowresources: Optional[VolumeResourceRequirements]
for volumes. The attributes in the classes are the same except forclaims
is removed inVolumeResourceRequirements
. Updated 4 examples that were using thiscluster_name
has been removed inObjectMeta
so is also removed in theWorkflow
class. It was never used by the Argo server (and is explicitly noted as an "ignored" field in the field description inObjectMeta
).The rest are changes in the Argo models (i.e. in
src/hera/workflows/models/io/argoproj/workflow/v1alpha1.py
), that will affect users using the models directly. i.e. They'll be (relatively1) stuck on the currentHera
version until they upgrade Argo to 3.6 if they are using the following classes in Argo<3.6:PodGC
structurally changed - see Hera does not have AW 3.6 types (pod_gc
onWorkflowTemplate
is not rendered correctly) #1292Artifact
prefixstr
)ContainerMixin
so no change on the Hera side)ModelClass.construct
as seen here.