Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTML] Update docs and add examples for Compute Plan and In-memory model usage. #2420

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

[HTML] Update docs and add examples for Compute Plan and In-memory model usage. #2420

wants to merge 1 commit into from

Conversation

cymbalrush
Copy link
Collaborator

@cymbalrush cymbalrush commented Dec 18, 2024 •
edited
Loading

@cymbalrush cymbalrush added the docs Contains documentation or clarification regarding docs (type) label Dec 18, 2024
@junpeiz
Copy link
Collaborator

junpeiz commented Dec 18, 2024

Could you confirm that your env's doc-related package versions are consistent / up-to-date with the ones specified in coremltools/reqs/docs.pip? I'm asking because the preview HTML has some regressions, for example, the box on the right side is empty:
image

junpeiz
junpeiz reviewed Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@junpeiz junpeiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this PR should only contain HTML related changes, so the docs-guides/_sources/source/mlmodel-utilities.md should be in your doc change PR that is going to be merged into main branch?

@cymbalrush
Copy link
Collaborator Author

cymbalrush commented Dec 18, 2024 •
edited
Loading

Regenerated the html, on my local machine the images load properly.

Screenshot 2024-12-18 at 11 05 44 AM

Screenshot 2024-12-18 at 12 58 47 PM

@cymbalrush
Copy link
Collaborator Author

cymbalrush commented Dec 18, 2024 •
edited
Loading

I do have a docs-guides change and when I do make clean; make html it has the docs-guides/_sources/source/mlmodel-utilities.md in the html directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junpeiz junpeiz junpeiz left review comments

@TobyRoseman TobyRoseman Awaiting requested review from TobyRoseman

@aseemw aseemw Awaiting requested review from aseemw

@YifanShenSZ YifanShenSZ Awaiting requested review from YifanShenSZ

Assignees
No one assigned
Labels
docs Contains documentation or clarification regarding docs (type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cymbalrush @junpeiz