-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs cases: fix compile error #2905
base: master
Are you sure you want to change the base?
Conversation
kernel/fs/cases/fs_stream_test.c:279:70: error: format ‘%zi’ expects argument of type ‘signed size_t’, but argument 4 has type ‘int’ [-Werror=format=] 279 | syslog(LOG_ERR, "len = %zi != return value from fwrite = %zi", | ~~^ | | | long int | %i 280 | len, ret); | ~~~ | | | int kernel/fs/cases/fs_stream_test.c:311:69: error: format ‘%zi’ expects argument of type ‘signed size_t’, but argument 4 has type ‘int’ [-Werror=format=] 311 | syslog(LOG_ERR, "len = %zi != return value from fread = %zi", | ~~^ | | | long int | %i 312 | len, ret); | ~~~ | | | int Signed-off-by: zhangshoukui <[email protected]>
…long unsigned int', but argument 3 has type 'size_t' Signed-off-by: Xiang Xiao <[email protected]>
[Experimental Bot, please feedback here] Yes, this PR likely meets the NuttX requirements, though it could be slightly improved. Strengths:
Weaknesses/Areas for Improvement:
Recommendation: Add the missing details mentioned above, especially the testing information. While the PR is likely acceptable as-is, providing more context will make it easier for reviewers to understand and approve the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @xiaoxiang781216 :-)
Thanks, @xiaoxiang781216 ! |
Summary
Impact
fix compiler warning
Testing
ci