Faces 5.0: Spec 1584 - Rely on CDI Class Scanning

[volosied]

For https://github.com/jakartaee/faces/issues/1584

Since CDI scanning is default now, I removed the USE_CDI_FOR_ANNOTATION_SCANNING configuration.

Question: Should we still have fallbacks 2 & 3?

TODO: Create JIRA if one doesn't exist. And investigate unit test failures...

[volosied]

Down to 6 failures:

[ERROR] Errors: 
[ERROR]   FacesConfiguratorDefaultValidatorsTestCase.testBeanValidationNotAvailable:213 » NullPointer
[ERROR]   FacesConfiguratorDefaultValidatorsTestCase.testDefaultBeanValidatorDisabled:186 » NullPointer
[ERROR]   FacesConfiguratorDefaultValidatorsTestCase.testDefaultBeanValidatorDisabledButPresentInFacesConfig:153 » NullPointer
[ERROR]   FacesConfiguratorDefaultValidatorsTestCase.testDefaultValidatorsClearedByLatterConfigFileWithEmptyElement:251 » NullPointer
[ERROR]   FacesConfiguratorDefaultValidatorsTestCase.testDefaultValidatorsNotClearedByLatterConfigFileWithNoElement:292 » NullPointer
[ERROR]   FacesConfiguratorDefaultValidatorsTestCase.testDefaultValidatorsOverwrittenByLatterConfigFile:333 » NullPointer

I'm not sure how to enable CDI in the AbstractJsfConfigurableMockTestCase super class. Unless I check for a null bean manager in the impl code.

java.lang.NullPointerException
	at org.apache.myfaces.cdi.util.CDIUtils.getOptional(CDIUtils.java:61)
	at org.apache.myfaces.config.annotation.DefaultAnnotationProvider.getAnnotatedClasses(DefaultAnnotationProvider.java:133)
	at org.apache.myfaces.config.annotation.AnnotationConfigurator.createFacesConfig(AnnotationConfigurator.java:84)
	at org.apache.myfaces.config.DefaultFacesConfigurationProvider.getAnnotationsFacesConfig(DefaultFacesConfigurationProvider.java:188)
	at org.apache.myfaces.config.DefaultFacesConfigurationMerger.getFacesConfigData(DefaultFac

[volosied]

Alternatively, we keep the config and switch it to false for the failng FacesConfiguratorDefaultValidatorsTestCase tests.

[tandraschko]

if the spec switches to to this behavior, we should completely remove the AnnotationProvider SPI IMO

[volosied]

As for removing the Annotation Provider, does the quarkus extension need it? I see there's a QuarkusAnnotationProvider.

[tandraschko]

yep, i see
then we should move the CDI logic to DefaultAnnotationProvider and remove the old stuff

[volosied]

Could you be more specific -- I don't quite follow which parts you mean?

[tandraschko]

I can take care of it If the Mojarra Team give their +1

[tandraschko]

i will close this for now and completly remove old scanning after we aligned on the spec change