[590] Add RFC template for XTable #604
Open
+55
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## Implementation | ||
| Describe the new thing you want to do in appropriate detail, how it fits into the project architecture. | ||
| Provide a detailed description of how you intend to implement this feature.This may be fairly extensive and have large subsections of its own. |
There was a problem hiding this comment.
You need to add \ at the end of a line or else it is rendering as own.Or
|
|
||
| ## Rollout/Adoption Plan | ||
|
|
||
| - What impact (if any) will there be on existing users? |
There was a problem hiding this comment.
Should we call out any breakage to existing APIs?
|
|
||
| ## Abstract | ||
|
|
||
| Describe the problem you are trying to solve and a brief description of why it’s needed |
There was a problem hiding this comment.
Nitpick: add a .
| Describe the problem you are trying to solve and a brief description of why it’s needed | ||
|
|
||
| ## Background | ||
| Introduce any much background context which is relevant or necessary to understand the feature and design choices. |
There was a problem hiding this comment.
any much -> any
| - What impact (if any) will there be on existing users? | ||
| - If we are changing behavior how will we phase out the older behavior? | ||
| - If we need special migration tools, describe them here. | ||
| - When will we remove the existing behavior |
There was a problem hiding this comment.
Combine this with 49?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important Read
What is the purpose of the pull request
Introduce RFC template to propose/review new technical specs in the project.
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.