Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Remove presto node.properties files #467

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daragu
Copy link
Contributor

@daragu daragu commented Jun 13, 2024

Important Read

hotfix

What is the purpose of the pull request

The presto/node.properties will be changed after run the docker demo, and this file is useless, we can delete it.

On branch presto
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   presto/node.properties

These are generated by presto docker container.
图片

Verify this pull request

local.

@daragu daragu closed this Jun 13, 2024
@daragu daragu reopened this Jun 13, 2024
@ghost
Copy link

ghost commented Jun 13, 2024

CI report:

Bot commands @xtable-bot supports the following commands:
  • @xtable-bot run azure re-run the last Azure build

@kristgpt
Copy link

@daragu why so many node.id=presto records are produced.

@daragu
Copy link
Contributor Author

daragu commented Jun 17, 2024

@daragu why so many node.id=presto records are produced.

Hi @kristgpt, these records are generated after execute start_demo.sh every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants