-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-72: Handling failed
TI state for AirflowFailException
& AirflowSensorTimeout
#44954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
December 16, 2024 09:22
amoghrajesh
changed the title
Aip72 failexception
AIP-72: Handling failed TI state for AirflowFailException & AirflowSensorTimeout
Dec 16, 2024
10 tasks
amoghrajesh
changed the title
AIP-72: Handling failed TI state for AirflowFailException & AirflowSensorTimeout
AIP-72: Handling Dec 17, 2024
failed
TI state for AirflowFailException
& AirflowSensorTimeout
kaxil
reviewed
Dec 17, 2024
kaxil
reviewed
Dec 17, 2024
kaxil
reviewed
Dec 17, 2024
kaxil
reviewed
Dec 17, 2024
kaxil
reviewed
Dec 17, 2024
kaxil
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On high-level it lgtm -- although please address the comments I had
kaxil
reviewed
Dec 17, 2024
kaxil
reviewed
Dec 17, 2024
kaxil
reviewed
Dec 17, 2024
Co-authored-by: Kaxil Naik <[email protected]>
Co-authored-by: Kaxil Naik <[email protected]>
@kaxil I will merge this PR once the CI is green to unblock the other PRs which are based on this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #44414
We already have support for handling terminal states from the task execution side as well as the task SDK client side. (almost) and failed state is part of the terminal state.
This PR extends the task runner's run function to handle cases when we have to fail a task:
AirflowFailException, AirflowSensorTimeout
. It is functionally very similar to #44786As part of failing a task, multiple other things also needs to be done like:
fail_stop
/ non teardown tasks in TASK SDK #44951Testing performed
End to End with Postman
Run airflow with breeze and run any DAG
Login to metadata DB and get the "id" for your task instance from TI table
Send a request to
fail
your taskOr using curl:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.