Refactor Sqlalchemy queries to 2.0 style (Part 6) #32645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanikumv
requested review from
dstandish,
kaxil,
XD-DENG and
ashb
as code owners
phanikumv
added
the
full tests needed
phanikumv
added
the
use public runners
phanikumv
force-pushed
the
sqla_serialized
branch
from
b8e2073 to
49c6562
Compare
uranusjr
reviewed
Jul 18, 2023
uranusjr
reviewed
Jul 18, 2023
uranusjr
reviewed
Jul 18, 2023
uranusjr
reviewed
Jul 18, 2023
uranusjr
reviewed
Jul 18, 2023
uranusjr
reviewed
Jul 18, 2023
phanikumv
force-pushed
the
sqla_serialized
branch
4 times, most recently
from
99224d1 to
ee39200
Compare
uranusjr
reviewed
Jul 20, 2023
uranusjr
approved these changes
Jul 20, 2023
ephraimbuddy
approved these changes
Jul 20, 2023
| ) | ||
| serialized_dag_db = session.execute( | ||
| select(cls.dag_hash, cls.processor_subdir).where(cls.dag_id == dag.dag_id) | ||
| ).first() |
There was a problem hiding this comment.
Should we use limit here?
There was a problem hiding this comment.
using limit doesnt work somehow
phanikumv
force-pushed
the
sqla_serialized
branch
from
83a2326 to
7a5d8c6
Compare
phanikumv
force-pushed
the
sqla_serialized
branch
from
7a5d8c6 to
9694640
Compare
ephraimbuddy
added
the
type:misc/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the effort to refactor the queries to sqlalchemy 2.0
related: #28723
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.