SQLA20: Replace Session.query(...).get by Session.get #29205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taragolis
requested review from
ryanahamilton,
ashb,
bbovenzi,
ephraimbuddy,
jedcunningham,
kaxil and
XD-DENG
as code owners
boring-cyborg
bot
added
area:API
Taragolis
changed the title
jedcunningham
approved these changes
Jan 27, 2023
| @@ -3687,7 +3687,6 @@ def complete_one_dagrun(): | |||
| for _ in range(5): | |||
| self.scheduler_job._do_scheduling(session) | |||
| complete_one_dagrun() | |||
| model: DagModel = session.query(DagModel).get(dag.dag_id) | |||
There was a problem hiding this comment.
I guess not, this model not use later in the code, we just make a query to DB and that all.
This part unchanged since it added in the end if 2021: #19528
|
Yeah, mostly because we have so many composite PKs, and using (Plus for whatever reason historically Airflow never use it. I think either due to a dislike of it, a misunderstanding of the SQLA session model or simply not knowing it exists) |
Taragolis
added
the
full tests needed
potiuk
approved these changes
Jan 28, 2023
|
Ok, lets do a full test. Just in case. |
kaxil
approved these changes
Jan 28, 2023
pierrejeambrun
added
the
changelog:skip
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
(cherry picked from commit 264ace5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #28723
Replace abstract
session.query(User).get(5)bysession.get(User, 5)(1.4/2.0 compatible). First from the list: 2.0 Migration - ORM UsageNote: most of the legacy usage found by regex:
query\(.*\.get\(so there is possible that unchanged part still exists.