P.O.C: Manage static settings with dynaconf #676
Draft
+30
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
reviewed
Dec 18, 2024
| root_path=caller_path, | ||
| **options | ||
| ) | ||
| # settings.update(get_dab_settings(...)) |
There was a problem hiding this comment.
yes... did this not work? Otherwise I generally follow this.
What about precedence? You're loading the default dab settings after the other stuff, but I expect that env vars take higher precedence than these file defaults.
There was a problem hiding this comment.
this works, I commented out because I was debugging.
The envvars will have higher precedence because the order will be defined on each component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P.O.C - Manage settings with Dynaconf