-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable color logs in CI #15719
base: devel
Are you sure you want to change the base?
Disable color logs in CI #15719
Conversation
This is the next step after #15717 |
As of opening this, working for:
still not working for
I think these are specific to management commands. |
Lifecycle is good
ok, this covers the main thing I wanted. |
Quality Gate passedIssues Measures |
Looking much better:
Very happy with this now. |
@if [ "$(VENV_BASE)" ]; then \ | ||
. $(VENV_BASE)/awx/bin/activate; \ | ||
fi; \ | ||
supervisord --pidfile=/tmp/supervisor_pid -n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've grown kind of tired of this pattern of make-calls-docker, then docker-calls-supervisord-entrpoint, then supervisord-calls-make.
While we could get more explicit about documenting "these targets are ran inside docker" vs "these targets are ran outside docker", in this case it makes more sense to just delete the unnecessary step.
SUMMARY
Trying to further cleanup the logs you can download as an artifact after a test run.
ISSUE TYPE
COMPONENT NAME