feat: Update collection arguments

[sean-m-sullivan]

SUMMARY

Update the injectors for the AAP credential type to work across collections

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

• Collection

AWX VERSION

24.6.1

ADDITIONAL INFORMATION

Related PR's:

• awx-plugins
• ansible.platform
• ansible.hub
• ansible.controller
• ansible.eda
• eda-server
• infra.aap_configuration - Done.

[AlanCoding]

Consistency is the most important thing for this. What other content is using these connection parameters? This?

https://galaxy.ansible.com/ui/repo/published/infra/aap_configuration/docs/

[sean-m-sullivan]

Consistency is the most important thing for this. What other content is using these connection parameters? This?

https://galaxy.ansible.com/ui/repo/published/infra/aap_configuration/docs/

This is the primary thing using it at the moment, and the installer using it as well, it was more Some Variables should be exposed to playbooks for use, lets set a standard.

[AlanCoding]

Looking good 👍

I got some more background on this initiative. It looks like you've already taken the lead in proposing these changes elsewhere. I fully support this, but want to wait a few days to assure we've solidified consensus.

[AlanCoding]

I'm actually not convinced this will work anymore. I expect that if the collection receives AAP_HOSTNAME then in that scenario specifically, it needs to append to use /api/controller/ as opposed to /api/. I don't see that.

I could test this manually to clarify specifically how it's not working, but there's no automated tests we can rely on right now.

[AlanCoding]

ansible/event-driven-ansible#347

The PR you created here is for the collection. There may be a needed change to eda-server as well.

https://github.com/ansible/eda-server/blob/ac4be90e413196e922bd255a04589711b25b818e/src/aap_eda/core/management/commands/create_initial_data.py#L302-L315

This is probably more consequential, since this is a credential type used in-app, most similar to the awx_plugins change you are making. At some point we hope to essentially merge the 2 CredentialType models, but we are not there yet, so the controller type is more-or-less duplicated in both places.

[sean-m-sullivan]

It may be needed, didn't know it was there will look and add that to the list

ansible/event-driven-ansible#347

The PR you created here is for the collection. There may be a needed change to eda-server as well.

https://github.com/ansible/eda-server/blob/ac4be90e413196e922bd255a04589711b25b818e/src/aap_eda/core/management/commands/create_initial_data.py#L302-L315

This is probably more consequential, since this is a credential type used in-app, most similar to the awx_plugins change you are making. At some point we hope to essentially merge the 2 CredentialType models, but we are not there yet, so the controller type is more-or-less duplicated in both places.

[AlanCoding]

I would prefer for the main name to be aap_token, otherwise looks alright.

[sean-m-sullivan]

Updated

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[PabloHiro]

Does this still make sense?

[AlanCoding]

agree, I think this is okay if it has no aliases, due to other recent changes

[PabloHiro]

Same with this. Not sure how to handle this so it is clear that OAUTH is coming from the Resource Server but is not available in Controller