Add description and label to demo jt #15598
Open
+19
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djyasin
approved these changes
Oct 23, 2024
thedoubl3j
approved these changes
Oct 23, 2024
TheRealHaoLiu
force-pushed
the
add-label-and-description-to-demo-jt
branch
from
a422904 to
cab92df
Compare
|
webknjaz
reviewed
Oct 23, 2024
| @@ -4,7 +4,7 @@ | |||
| from django.core.management.base import BaseCommand | |||
| from django.db import transaction | |||
| from crum import impersonate | |||
| from awx.main.models import User, Organization, Project, Inventory, CredentialType, Credential, Host, JobTemplate | |||
| from awx.main.models import User, Organization, Project, Inventory, CredentialType, Credential, Host, JobTemplate, Label | |||
There was a problem hiding this comment.
@TheRealHaoLiu could you document how you tested this change?
Codecov reveals that nothing in this module is ever hit in the test suite: https://app.codecov.io/gh/ansible/awx/pull/15598#f9e72d3f63929dd1c3c1d53def0b69c6-L7. So the CI wouldn't be able to catch any regressions.
webknjaz
reviewed
Oct 23, 2024
| @@ -50,9 +50,11 @@ def _handle(self): | |||
|
|
|||
| ssh_type = CredentialType.objects.filter(namespace='ssh').first() | |||
| c, _ = Credential.objects.get_or_create( | |||
| credential_type=ssh_type, name='Demo Credential', inputs={'username': getattr(superuser, 'username', 'null')}, created_by=superuser | |||
| credential_type=ssh_type, | |||
There was a problem hiding this comment.
Is this a formatting-only change? I don't see any difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add description and label to the demo job template
request by @jamestalton
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION