Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAA bugfix and code refactor #495

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stalabi1
Copy link
Collaborator

SUMMARY
  • I updated the test cases and added a sleep in config to account for SONiC code changes. I opened a JIRA concerning a device lockout issue with the previous test cases so these test case changes may be reverted based on the outcome of JIRA.
  • I updated the overridden state to handle the case of 'have' being a subset of 'want'.
  • I refactored the delete state code to make use of 'get_diff_aaa' to calculate the deleted commands.
  • I added a method to remove defaults.
  • I applied Arun's suggestions on how to resolve ansible-lint errors for the regression files.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

sonic_aaa

OUTPUT

regression-2024-12-18-13-12-14.html.pdf

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

@stalabi1 stalabi1 added the bug Something isn't working label Dec 18, 2024
@stalabi1 stalabi1 added this to the v3.1.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant