Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate fixes #29159

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Renovate fixes #29159

merged 4 commits into from
Dec 17, 2024

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 17, 2024

ci: remove ignorePaths paths for pnpm-lock.yaml
This does not work as expected because the paths are expected to be package files.

build: update engines field in package.json
This commit removes the yarn engine field. The packageManager version was previously removed, causing Renovate to pick up an outdated Yarn version. Additionally, Yarn Berry does not use this field, rendering it unnecessary.

build: workaround for ERROR: An error occurred during the fetch of repository 'npm2'

In some cases yarn bazel run @npm2//:sync will fail in the first run see: aspect-build/rules_js#1445 as a workaround we run a build before.

ERROR: An error occurred during the fetch of repository 'npm2':
   Traceback (most recent call last):
        File "/usr/local/google/home/alanagius/.cache/bazel/_bazel_alanagius/2fa837e4c5ce941f68b762e5f8e7dc4d/external/aspect_rules_js/npm/private/npm_translate_lock.bzl", line 112, column 21, in _npm_translate_lock_impl
                fail(msg)
Error in fail:

INFO:

This commit removes the `yarn` engine field. The `packageManager` version was previously removed, causing Renovate to pick up an outdated Yarn version. Additionally, Yarn Berry does not use this field, rendering it unnecessary.
This does not work as expected because the paths are expected to be package files.
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Dec 17, 2024
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Dec 17, 2024
…epository 'npm2'`

In some cases `yarn bazel run @npm2//:sync` will fail in the first run see: aspect-build/rules_js#1445 as a workaround we run a build before.

```
ERROR: An error occurred during the fetch of repository 'npm2':
   Traceback (most recent call last):
        File "/usr/local/google/home/alanagius/.cache/bazel/_bazel_alanagius/2fa837e4c5ce941f68b762e5f8e7dc4d/external/aspect_rules_js/npm/private/npm_translate_lock.bzl", line 112, column 21, in _npm_translate_lock_impl
                fail(msg)
Error in fail:

INFO: pnpm-lock.yaml file updated. Please run your build again.
```
@alan-agius4 alan-agius4 force-pushed the engine-renovate-update branch from 2311b69 to 9448f40 Compare December 17, 2024 11:29
Explicitly disable Renovate updates targeting the `0.0.0-PLACEHOLDER` and `0.0.0-EXPERIMENTAL-PLACEHOLDER` versions. These placeholders are not intended for automated updates and require manual handling.
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 17, 2024
@alan-agius4 alan-agius4 merged commit e5ed172 into angular:main Dec 17, 2024
29 checks passed
@alan-agius4 alan-agius4 deleted the engine-renovate-update branch December 17, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants