Progress bar for current playing track #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… track. It can be interacted with but the slider behaves incorrectly when the user *slides it* instead of simply clicking somewhere on the bar : this is due to the fact that the value of the slider is updated by querying player API
anavarr
force-pushed
the
track-progress-bar
branch
from
38f6565 to
3ffdb5f
Compare
anavarr
changed the title
|
I would like to see this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a progress bar for the current playing track
Current look
Current features
display the current timecode of the video and the total length : a slider is updated to show the video progress, this slider can be interacted with to jump somewhere in the video
Limitations
the slider doesn't work well when slided but if the user simply clicks somewhere on the bar it works.
Progress behaves weirdly because the slider value is updated frequently by querying the player GetCurrentTime API, the updates happen when the user is dragging the slider, making it go back and forth between the currentTime and the mouse position on the bar