Add get_uri method to term.py class #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
reviewed
Jun 8, 2022
| if prefix in ontology.metadata.idspaces: | ||
| return "{}{}".format(ontology.metadata.idspaces[prefix][0], local) | ||
| else: | ||
| return "http://purl.obolibrary.org/obo/{}_{}".format(prefix, local) |
There was a problem hiding this comment.
probably not smart to assume OBO URIs for any old ontology. This should raise an exception like a KeyError if there's no idspace defined for the prefix.
There was a problem hiding this comment.
@cthoyt : Not necessarily, because the prefix could also originate from an import. In that case, you'd have to check the ontology attribute of imported prefixes.
althonos
force-pushed
the
master
branch
2 times, most recently
from
a690871 to
1e55509
Compare
althonos
force-pushed
the
master
branch
2 times, most recently
from
481b91f to
7eda5d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving #117, added a method
get_uri()toterm.pyclass.@althonos what's your take on this?