Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make spacing consistent for a list of links with paragraph tags #4437

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions spec/dummy/app/views/layouts/dummy_public_layout.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
<%= render 'govuk_publishing_components/components/layout_for_public', {
emergency_banner: '<div class="govuk-width-container"><p class="govuk-body">This is the emergency banner slot.</p></div>',
global_bar: '<div class="govuk-width-container govuk-!-margin-top-2"><p class="govuk-body">This is the global bar slot.</p></div>',
title: "Example public page",
for_static: true,
show_explore_header: true,
Expand Down
50 changes: 39 additions & 11 deletions spec/dummy/app/views/welcome/public_example.html.erb
Original file line number Diff line number Diff line change
@@ -1,18 +1,46 @@
<h1 class="govuk-heading-xl">Hello! I am an example public GOV.UK page</h1>
<p class="govuk-body govuk-!-margin-bottom-8">Find out about GOV.UK, including the use of cookies, accessibility of the site, the privacy notice and terms and conditions of use.</p>

<p class="govuk-body">
Pages with the public layout can use some GOV.UK styles. For example, the grid:
</p>

<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<h1 class="govuk-heading-m">Two-thirds column</h1>
<p class="govuk-body">This is a paragraph inside a two-thirds wide column</p>
</div>

<div class="govuk-grid-column-one-third">
<h3 class="govuk-heading-m">One-third column</h3>
<p class="govuk-body">This is a paragraph inside a one-third wide column</p>
<div class="govuk-grid-column-two-thirds">
<%= render "govuk_publishing_components/components/document_list", {
remove_top_border: true,
items: [
{
link: {
text: "About GOV.UK",
path: "/become-an-apprentice",
description: "Information about the website and the team that are building it",
full_size_description: true
}
},
{
link: {
text: "Accessibility",
path: "/become-an-apprentice",
description: "How new services are developed on GOV.UK and what it means for users",
full_size_description: true
}
},
{
link: {
text: "Browsers",
path: "/become-an-apprentice",
description: "Information about browsers and how to upgrade yours+",
full_size_description: true
}
},
{
link: {
text: "Cookies",
path: "/become-an-apprentice",
description: "How cookies are used on GOV.UK and each cookie’s purpose",
full_size_description: true
}
}
]
} %>
</div>
</div>
<% content_for :before_content do %>
Expand Down
Loading