Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the test group across 1 directory with 2 updates #5546

Closed
wants to merge 3 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 9, 2024

Important

Do not merge, we'll merge #5550 for enabling skipLibCheck on its own for a better history.

Bumps the test group with 2 updates in the / directory: puppeteer and @axe-core/puppeteer.

Updates puppeteer from 23.6.0 to 23.10.1

Release notes

Sourced from puppeteer's releases.

puppeteer-core: v23.10.1

23.10.1 (2024-12-04)

Bug Fixes

puppeteer: v23.10.1

23.10.1 (2024-12-04)

Miscellaneous Chores

  • puppeteer: Synchronize puppeteer versions

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • puppeteer-core bumped from 23.10.0 to 23.10.1

puppeteer-core: v23.10.0

23.10.0 (2024-12-03)

Features

Bug Fixes

  • stop calling bringToFront when taking page screenshots (#13336) (6da2cb4)

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @​puppeteer/browsers bumped from 2.4.1 to 2.5.0

puppeteer: v23.10.0

23.10.0 (2024-12-03)

... (truncated)

Commits

Updates @axe-core/puppeteer from 4.10.0 to 4.10.1

Release notes

Sourced from @​axe-core/puppeteer's releases.

Release 4.10.1

What's Changed

New Contributors

Full Changelog: dequelabs/axe-core-npm@v4.10.0...v4.10.1

Changelog

Sourced from @​axe-core/puppeteer's changelog.

4.10.1 (2024-10-29)

Bug Fixes

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the test group with 2 updates in the / directory: [puppeteer](https://github.com/puppeteer/puppeteer) and [@axe-core/puppeteer](https://github.com/dequelabs/axe-core-npm).


Updates `puppeteer` from 23.6.0 to 23.10.1
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@puppeteer-v23.6.0...puppeteer-v23.10.1)

Updates `@axe-core/puppeteer` from 4.10.0 to 4.10.1
- [Release notes](https://github.com/dequelabs/axe-core-npm/releases)
- [Changelog](https://github.com/dequelabs/axe-core-npm/blob/develop/CHANGELOG.md)
- [Commits](dequelabs/axe-core-npm@v4.10.0...v4.10.1)

---
updated-dependencies:
- dependency-name: puppeteer
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: test
- dependency-name: "@axe-core/puppeteer"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: test
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels Dec 9, 2024
@dependabot dependabot bot requested a review from a team December 9, 2024 10:33
Copy link

github-actions bot commented Dec 9, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 118.41 KiB
dist/govuk-frontend-development.min.js 42.7 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 92.79 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 87.12 KiB
packages/govuk-frontend/dist/govuk/all.mjs 1.25 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 1.74 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 118.4 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 42.69 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 7.13 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 82.57 KiB 40.4 KiB
accordion.mjs 26.58 KiB 13.41 KiB
button.mjs 9.09 KiB 3.78 KiB
character-count.mjs 25.39 KiB 10.9 KiB
checkboxes.mjs 7.81 KiB 3.42 KiB
error-summary.mjs 10.99 KiB 4.54 KiB
exit-this-page.mjs 20.2 KiB 10.34 KiB
header.mjs 6.46 KiB 3.22 KiB
notification-banner.mjs 9.35 KiB 3.7 KiB
password-input.mjs 18.24 KiB 8.33 KiB
radios.mjs 6.81 KiB 2.98 KiB
service-navigation.mjs 6.44 KiB 3.26 KiB
skip-link.mjs 6.4 KiB 2.76 KiB
tabs.mjs 12.04 KiB 6.67 KiB

View stats and visualisations on the review app


Action run for 270d5dc

@romaricpascal romaricpascal marked this pull request as draft December 13, 2024 15:11
@romaricpascal
Copy link
Member

I've enabled TypeScript's skipLibCheck to assess its impact (#5549), as we need to discuss before we merge, I've put the PR back in draft.

We're explicitely using it to import types so it should be listed as a devDependency
@romaricpascal romaricpascal force-pushed the dependabot/npm_and_yarn/test-381fc085d0 branch from d2b0991 to b492d66 Compare December 16, 2024 13:14
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-5546 December 16, 2024 13:18 Inactive
@romaricpascal
Copy link
Member

romaricpascal commented Dec 16, 2024

The TypeScript issue is now solved 🥳 I needs the two extra commits to work:

  1. because we use axe-core directly within our code through import('axe-core') to access types, we need to have it listed as part of our devDependencies. This leaves us with some type issues within Puppeteer's code rather than ours
  2. adding skipLibCheck, originally enabled for testing its impact, tells TypeScript to not bother with issues inside Puppeter's code, giving us a way out 🥳

@romaricpascal romaricpascal marked this pull request as ready for review December 16, 2024 13:20
@romaricpascal romaricpascal marked this pull request as draft December 16, 2024 13:27
@romaricpascal
Copy link
Member

Closing as it's been superseeded by #5553 😊

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 16, 2024

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

To ignore these dependencies, configure ignore rules in dependabot.yml

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/test-381fc085d0 branch December 16, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants