Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows CI: use preinstalled CMake instead installing specific version #2438

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

SimeonEhrig
Copy link
Member

Uninstalling the pre installed CMake version is not possible.

https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md#tools

- Uninstalling the pre installed CMake version is not possible
@@ -115,7 +115,7 @@ jobs:
container: ubuntu:20.04
- name: windows_cl-2022_debug_analysis
os: windows-2022
env: {ALPAKA_CI_CXX: cl.exe, ALPAKA_CI_CL_VER: 2022, CMAKE_BUILD_TYPE: Debug, ALPAKA_BOOST_VERSION: 1.78.0, ALPAKA_CI_CMAKE_VER: 3.25.3, ALPAKA_CI_ANALYSIS: ON, alpaka_DEBUG: 2}
env: {ALPAKA_CI_CXX: cl.exe, ALPAKA_CI_CL_VER: 2022, CMAKE_BUILD_TYPE: Debug, ALPAKA_BOOST_VERSION: 1.78.0, ALPAKA_CI_CMAKE_VER: 3, ALPAKA_CI_ANALYSIS: ON, alpaka_DEBUG: 2}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would "3" work for any 3.x installed or it means directly 3.0 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the package manager we use to install cmake does not supports minor versions and will use something modern.
Lets wait for a response from @SimeonEhrig

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 means only the major version is specified. At the moment CMake 3.31 is preinstalled. If MS is updating the image we get a another version of CMake 3 (probably something newer than 3.31).
I cannot uninstall the preinstalled version. Therefore I cannot decide what we use and I thought CMake 4 will be not released soon the the version 3 shows that we only get CMake 3.

@psychocoderHPC psychocoderHPC merged commit 2a513e7 into alpaka-group:develop Dec 12, 2024
22 checks passed
@SimeonEhrig
Copy link
Member Author

I opened an issue, that the problem will be fixed: actions/runner-images#11174
But to be honest, I don't believe that it will be fixed. MS never fixed one of my bug reports :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants