Selection box

[softwareCobbler]

This implements a "selectionBox" feature in Network's interaction module. With this option enabled, the user can press CTRL and left click and then drag a box around the canvas. Let go and it selects the nodes and/or edges within the box (there are option flags the user can set to have it select nodes / edges).
Open to feedback!
This was briefly discussed in #4233.
Thanks!

[softwareCobbler]

Quick video example of feature

[jgorene]

A priori, I didn't encounter any bugs at least after a few tests.
Subject to further testing, this seems ready to be implemented at the latest on v4.22.
Good work !

[softwareCobbler]

considering the line width option - since CanvasRenderingContext2D.lineWidth is in coordinate space, I'm not certain how to provide a sane default. The value the user provides will change in apparent thickness as the zoom scale changes. Recalculating upon camera scale changes is the obvious solution, but I don't know quite what units the user expects to see.
Should a value of 1.0 always be 1 screen pixel? Or 1% of the total canvas area?

[jgorene]

@softwareCobbler Indeed and it's already very good like that, no problem 😌
I still have a lot to learn and it will take me a little more time to properly analyze the new option , anyway.

@mojoaxel Just by the way and nothing to do with this new interaction option but it seems that "zoomSpeed" option is obsolete... but maybe I missed something?

[softwareCobbler]

Got the lineWidth option up and running for this:

• It is a value in screen pixels, the canvas zoom should not affect the pixel count.
• lineWidth is kept greater than or equal to zero (negative values are forced to 0), and while the user can pass in real numbers, the passed-in values are rounded down to the nearest integer.
• a zero value means we draw no border, and just fill in the appropriate fillRect
• canvas bounds clamping has been adjusted to deal with different sized lineWidth's

[mojoaxel]

👍

[softwareCobbler]

cherry-picked this into #4256 to provide a more logical separation of concern (it's a bit out of place in this PR)

[mojoaxel]

@softwareCobbler Please consider moving this pull-request over to vis-network! Also we are always looking for people that might be interesting in helping maintaining 😉

[softwareCobbler]

Haha thought it was DOA--when I can scrape together some time I'd be happy to. Thanks, Dave R.

…

On Tue, Jul 23, 2019, 7:41 AM Alexander Wunschik ***@***.***> wrote: @softwareCobbler <https://github.com/softwareCobbler> Please consider moving this pull-request over to vis-network <https://github.com/visjs/vis-network>! Also we are always looking for people that might be interesting in helping maintaining 😉 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4242?email_source=notifications&email_token=AEPAW2ACVLDDXO4ZWMQM46LQA34BNA5CNFSM4GT7NWR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2S7LHI#issuecomment-514192797>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEPAW2FQFAAAHQD6V3UXROLQA34BNANCNFSM4GT7NWRQ> .