This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Fix: Network nodes ignoring widthConstraint after hover #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes labels being split along the wrong lines. It doesn't take font modifiers into account, though, so still might be wrong in some circumstances. Just less wrong than before. Fixes almende#3928 for the most part. Arrowheads on edges can still be slightly misaligned in some cases.
Example test page for validating bug regression.
moppius
commented
Oct 11, 2018
| @@ -735,7 +735,7 @@ class Label { | |||
| state.width = this.fontOptions.minWdt; | |||
| } | |||
|
|
|||
| this.size.labelHeight =state.height; | |||
| this.size.labelHeight = state.height; | |||
There was a problem hiding this comment.
This isn't vital to the bug fix, but it was an inconsistency from the coding standard that I figured I should fix, since I was editing around there anyway.
29 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue where the
widthConstraintvalue of a node appears to be ignored after the mouse has hovered over a node.I tracked this down to the
ctxnot being initialized correctly the second time the nodes are refreshed, leading to an incorrect font face and size being supplied to the method that splits long text strings, which causes the measurements for the calculated pixel size of the string to be entirely incorrect.This bug has been reported in a few different issues - see the discussion thread on this #3928 for my investigation and reasoning for the fix. I basically just pass the context through in another couple of places to ensure it's set before the string split is calculated.
I've added an example HTML file to validate the issue as hoverLabelSplitterEdgeCase.html in the existing test/network/ folder.
This PR fixes #3872 and fixes #3928 (although one should probably be closed as a dupe).