Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: auth, dynamodb, eventbridge, firehose, ... 2.25.70 (was 2.25.16) #3234

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

scala-steward
Copy link
Contributor

About this PR

📦 Updates

  • software.amazon.awssdk:auth
  • software.amazon.awssdk:dynamodb
  • software.amazon.awssdk:eventbridge
  • software.amazon.awssdk:firehose
  • software.amazon.awssdk:kinesis
  • software.amazon.awssdk:lambda
  • software.amazon.awssdk:sns
  • software.amazon.awssdk:sqs

from 2.25.16 to 2.25.70

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "software.amazon.awssdk" }
}]
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new deprecation makes compilation fail

[error] /home/runner/work/alpakka/alpakka/sqs/src/main/scala/akka/stream/alpakka/sqs/scaladsl/SqsSource.scala:37:14: method attributeNamesWithStrings in trait Builder is deprecated
[error]             .attributeNamesWithStrings(settings.attributeNames.map(_.name).asJava)
[error]              ^

@ennru
Copy link
Member

ennru commented Sep 30, 2024

Scala 3 compilation fails. https://github.com/akka/alpakka/actions/runs/11105260282/job/30851041683?pr=3234#step:5:850

[error] -- [E057] Type Mismatch Error: /home/runner/work/alpakka/alpakka/s3/src/main/scala/akka/stream/alpakka/s3/settings.scala:599:21 
[error] 599 |            val creds = if (c.hasPath(tokenPath)) {

@ennru
Copy link
Member

ennru commented Oct 2, 2024

The Scala 3 changes make Scala 2 compilation fail

[info] compiling 21 Scala sources to /home/runner/work/alpakka/alpakka/sqs/target/scala-2.13/classes ...
[error] /home/runner/work/alpakka/alpakka/s3/src/main/scala/akka/stream/alpakka/s3/settings.scala:19:46: Unused import
[error] import software.amazon.awssdk.utils.builder.{CopyableBuilder, ToCopyableBuilder}
[error]                                              ^
[error] /home/runner/work/alpakka/alpakka/s3/src/main/scala/akka/stream/alpakka/s3/settings.scala:19:63: Unused import
[error] import software.amazon.awssdk.utils.builder.{CopyableBuilder, ToCopyableBuilder}
[error]                                                               ^
[error] two errors found

@ennru
Copy link
Member

ennru commented Oct 2, 2024

@sebastian-alfers
Copy link
Contributor

Not sure what is going on, will skip this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants