Address issue with subprocess and stdint
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dale-wahl
added a commit
to digitalmethodsinitiative/4cat
that referenced
this pull request
Oct 26, 2022
Merged
|
I fixed this and published it in my fork: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is main to address the issue described here: #98
It's mostly an issue with
subprocessandffmpeg, but videohash is susceptible to it. Let me know if you have any questions.I also added a bit to allow me to save the
ffmpeglogs (which I needed at first to diagnose what was going on). You can keep it at your leisure, but I left it as optional.Thanks again for this library. It's a very good idea and I'm looking forward to experimenting more with the various results!