Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10171/5185f93 backport][3.12] Stream unpauses protocol before releasing connection #10180

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 18, 2024

(cherry picked from commit 5185f93)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Dec 18, 2024
@bdraco bdraco changed the title Stream unpauses protocol before releasing connection (#10171) [PR #10171/5185f93) backport][3.12] Stream unpauses protocol before releasing connection Dec 18, 2024
@bdraco bdraco changed the title [PR #10171/5185f93) backport][3.12] Stream unpauses protocol before releasing connection [PR #10171/5185f93 backport][3.12] Stream unpauses protocol before releasing connection Dec 18, 2024
Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #10180 will not alter performance

Comparing patchback/backports/3.12/5185f932407947fbbabd31c5dc6d72abc5c54171/pr-10171 (2dbde4c) with 3.12 (d7e4e61)

Summary

✅ 47 untouched benchmarks

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (d7e4e61) to head (2dbde4c).
Report is 1 commits behind head on 3.12.

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.12   #10180   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         123      123           
  Lines       37208    37228   +20     
  Branches     4476     4477    +1     
=======================================
+ Hits        36489    36509   +20     
  Misses        542      542           
  Partials      177      177           
Flag Coverage Δ
CI-GHA 97.95% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.66% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.59% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.78% <100.00%> (-0.01%) ⬇️
Py-3.10.11 96.63% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.17% <100.00%> (-0.04%) ⬇️
Py-3.11.11 97.23% <100.00%> (-0.01%) ⬇️
Py-3.11.9 96.70% <100.00%> (-0.01%) ⬇️
Py-3.12.8 97.72% <100.00%> (+<0.01%) ⬆️
Py-3.13.1 97.71% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.56% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.13% <100.00%> (+0.03%) ⬆️
Py-pypy7.3.16 96.70% <100.00%> (-0.01%) ⬇️
VM-macos 96.78% <100.00%> (-0.01%) ⬇️
VM-ubuntu 97.66% <100.00%> (+<0.01%) ⬆️
VM-windows 94.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review December 18, 2024 18:56
@bdraco bdraco enabled auto-merge (squash) December 18, 2024 18:56
@bdraco bdraco merged commit a3a5716 into 3.12 Dec 18, 2024
33 checks passed
@bdraco bdraco deleted the patchback/backports/3.12/5185f932407947fbbabd31c5dc6d72abc5c54171/pr-10171 branch December 18, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants