AG-13489 Remove unused code & clean up #3285
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is step 1 to untangle all the inter-dependencies with all various different managers.
We need offsets relative to the HTMLElement that we are listening to. The RegionManager has canvasXY for that. These offsets are useful, so add a generalised version of these to MouseWidgetEvent: currentXY, which are offsets relative to the sourceEvent.currentTarget (which is the widget that is listening for events). Also, add listeners to the containerWidget. This is because the zoom toolbar is not a descendant of .ag-charts-series-area, so a 'mouseleave' is fired whenever the pointer hovers over a zoom button, which hides the toolbar. We don't want that. However, the zoom toolbar is a descendant of .ag-charts-canvas-container so we can add a listener there instead. This also has the added affect of showing the zoom toolbar when hovering over the axes (when onHover's bounds hit-testing logic is true), which is the expected behaviour in production.
This reduces code duplication and improves readability.
This reduces code duplication, and also makes it easier to see which parts of the codebase share common bitmasks for `InteractionManager.isState()`.
This file adds unnecessary complexity. Eventually, we'll just be using something like WidgetEvent.preventDefault().
|
Snapshots automatically updated, please review before merge: diff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-13489
Depends on: