sign node label #467
sign node label #467
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
Co-authored-by: Martijn Verburg <[email protected]>
github-actions
bot
added
documentation
generation
| @@ -485,6 +485,7 @@ class Build { | |||
| Run the Sign downstream job. We run this job on windows and jdk8 hotspot & jdk13 mac builds. | |||
| The job code signs and notarizes the binaries so they can run on these operating systems without encountering issues. | |||
| */ | |||
| def SIGN_NODE_LABEL = DEFAULTS_JSON['signNodeLabel'] | |||
There was a problem hiding this comment.
It is better to move this definition to the function build() to be visible to sign(), signInstaller() and probably other functions.
|
context.node('eclipse-codesign') , feels this node is also used to sign jmods. @andrew-m-leonard is it good to update the line mentioned here to `context.node("${SIGN_NODE_LABEL}")? |
|
maybe ask AdamBrousseau to take a look too, since he is the one created original issue |
| /* groovylint-disable-next-line VariableTypeRequired */ | ||
| def nodeFilter = "${SIGN_NODE_LABEL}" |
There was a problem hiding this comment.
| /* groovylint-disable-next-line VariableTypeRequired */ | |
| def nodeFilter = "${SIGN_NODE_LABEL}" | |
| String nodeFilter = "${SIGN_NODE_LABEL}" |
|
@cornelia247 need a rebase first |
|
this has been stale for over a year, converting to "draft", if no longer needed please close. |
Parameterized the SIGN_NODE_LABEL to allow users conveniently change defaults #51