fix: rename argument parameters

[sakshi1215]

fixes #433
Signed-off-by: sakshi1215 [email protected]

[github-actions]

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,19"

[sakshi1215]

Hi @zdtsw can you please review this?

[sakshi1215]

Hi @karianna @zdtsw can you please take a look again?

[zdtsw]

Ping @AdamBrousseau to double check if these two parameters need to be updated for your Jenkins job

[AdamBrousseau]

Is there a manual update needed to job(s) or will they automatically regenerate with the updated names?

[zdtsw]

Is there a manual update needed to job(s) or will they automatically regenerate with the updated names?
the job should be re-generated accordingly with new parameter's name.
but if you have anything else calls such job, e.g remote trigger with parameters, that need to be updated manually.

[sakshi1215]

@karianna @zdtsw @AdamBrousseau Is this good to be merged?

[AdamBrousseau]

Approving from a Semeru perspective.

[zdtsw]

run tests

[eclipse-temurin-bot]

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[zdtsw]

my bad, should have considered this rename from CLEAN_WORKSPACE to CLEAN_WORKSPACE_BEFORE would require the change in the class IndividualBuildConfig, which is not in the scope of this git repo.

[sakshi1215]

Can I tru that change too? Which repo stored the buildConfig?

…

On Wed, 12 Oct 2022 at 10:19 PM, Wen Zhou ***@***.***> wrote: ***@***.**** commented on this pull request. my bad, should have consider this change would require the change in the class IndividualBuildConfig, which is not in the scope of this git repo. — Reply to this email directly, view it on GitHub <#440 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANF3CEDX2LQ2Y5ZWAD4MC4LWC3TYNANCNFSM6AAAAAARBIOUII> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[karianna]

This is good but needs to go in with corresponding fix in the other repo

[karianna]

@sakshi1215 It's in the jenkins-helper repo: https://github.com/adoptium/jenkins-helper/blob/9fd063790c64a7cf2f9ee38c4bf4655f430d8be6/src/common/IndividualBuildConfig.groovy

[sakshi1215]

@karianna @zdtsw Here is the PR adoptium/jenkins-helper#43

[andrew-m-leonard]

Looks okay, but not sure we should merge just before a release?

[andrew-m-leonard]

Actually we'd need to change this as well: https://github.com/adoptium/jenkins-helper/blob/9fd063790c64a7cf2f9ee38c4bf4655f430d8be6/src/common/IndividualBuildConfig.groovy#L58

[sakshi1215]

Actually we'd need to change this as well: https://github.com/adoptium/jenkins-helper/blob/9fd063790c64a7cf2f9ee38c4bf4655f430d8be6/src/common/IndividualBuildConfig.groovy#L58

Its already done @andrew-m-leonard adoptium/jenkins-helper#43

[andrew-m-leonard]

Actually we'd need to change this as well: https://github.com/adoptium/jenkins-helper/blob/9fd063790c64a7cf2f9ee38c4bf4655f430d8be6/src/common/IndividualBuildConfig.groovy#L58

Its already done @andrew-m-leonard adoptium/jenkins-helper#43

excellent

[karianna]

Will merge with the jenkins helper fix post release.