Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker image #550

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add docker image #550

wants to merge 7 commits into from

Conversation

tmaier
Copy link

@tmaier tmaier commented Jan 17, 2023 •
edited
Loading

This is my try to add a docker image. This would close #262.

The image works, but there are some things not perfect and I am happy for suggestions/contributions.

  • The image built gets the label based on the name of the branch. In our case, master
  • We should have a latest label
  • We should have the ability to build each official release, with release version as label
  • It currently builds based on the npm package, not directly the source code of the repository. This means one must update CRITICAL_VERSION in Dockerfile after each release
  • Update of README is missing

If you are looking at this, just to find a working and recent docker image, see https://github.com/tmaier/critical/pkgs/container/critical

@tmaier tmaier mentioned this pull request Jan 17, 2023
Open
@bezoerb
Copy link
Collaborator

bezoerb commented Jan 25, 2023

Can anyone with Docker experience take a look at this please?

@tmaier
Copy link
Author

tmaier commented Feb 21, 2024

Hi @bezoerb, is there anything I can do to get this merged? I would like to stop having a fork, even so it is trivial for me at that point.

adonyssantos
adonyssantos approved these changes Mar 30, 2024
View reviewed changes
Copy link

@adonyssantos adonyssantos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks good to merge. 👀
Just check a few suggestions I left.

Dockerfile Outdated Show resolved Hide resolved
.github/workflows/docker.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonyssantos adonyssantos adonyssantos approved these changes

Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Official docker image
3 participants
@tmaier @bezoerb @adonyssantos