rp2pio: Add sideset_pindirs parameter to StateMachine constructor
#9849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows use of PIO programs that need to control pin *direction* from the side set portion of the instruction.
|
ping @jchawks -- I wrote this but didn't test it. Please test if you have a chance. |
pio/i2c/i2c.pio:.side_set 1 opt pindirs
pio/onewire/onewire_library/onewire_library.pio:.side_set 1 pindirspico-examples uses this for i2c and onewire implementations fwiw |
|
Thank you!! I got sidetracked and have been unable to get traction on this.
Will try this shortly.
…________________________________
From: Jeff Epler ***@***.***>
Sent: Sunday, December 1, 2024 11:18 AM
To: adafruit/circuitpython ***@***.***>
Cc: Curren, Joe (All Sensors) ***@***.***>; Mention ***@***.***>
Subject: Re: [adafruit/circuitpython] rp2pio: Add `sideset_pindirs` parameter to StateMachine constructor (PR #9849)
WARNING
**This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.**
pio/i2c/i2c.pio:.side_set 1 opt pindirs
pio/onewire/onewire_library/onewire_library.pio:.side_set 1 pindirs
pico-examples uses this for i2c and onewire implementations fwiw
—
Reply to this email directly, view it on GitHub<#9849 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BAXWSFPD37E4WL6DSM6VDJT2DNOHHAVCNFSM6AAAAABSZ4PMFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJQGIYTKMBRGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows use of PIO programs that need to control pin direction from the side set portion of the instruction.
Closes #9630
Will need an associated update to rp2pio to enable the assembler directive