Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB Reattach fixes + Specify reset time remaining + secrets != 0xFF #672

Merged
merged 4 commits into from
Dec 21, 2024

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Dec 17, 2024

This is desired with the pico2w release (with #664 ) to improve user first run experience

@tyeth tyeth force-pushed the tinyusb-reattach-print-reset-time branch from 36ae4d2 to 04f1c3c Compare December 17, 2024 23:09
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses the TinyUSB reattach issue we've been seeing and I like the count-up WDT feed function.

One small comment for code clarity:

src/Wippersnapper.cpp Show resolved Hide resolved
@tyeth tyeth force-pushed the tinyusb-reattach-print-reset-time branch from fac995a to f87a208 Compare December 19, 2024 17:43
@tyeth tyeth requested a review from brentru December 20, 2024 18:51
@tyeth
Copy link
Contributor Author

tyeth commented Dec 20, 2024

@brentru this one updates haltError to use an optional time argument, and parameterises the timeouts

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner! LGTM!

@tyeth tyeth merged commit f46c204 into adafruit:main Dec 21, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants