Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:electron: Fix export on mac #3250

Merged

Conversation

MikesGlitch
Copy link
Contributor

@MikesGlitch MikesGlitch commented Aug 12, 2024

Fixes: #2907

Screen Recording 2024-08-12 at 20 17 52

Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit a9b73fb
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66ba843d113d010008bc96e7
😎 Deploy Preview https://deploy-preview-3250.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Aug 12, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.94 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 77.55 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 27.55 kB 0%
static/js/wide.js 241.25 kB 0%
static/js/ReportRouter.js 1.24 MB 0%
static/js/index.js 3.22 MB 0%

Copy link
Contributor

github-actions bot commented Aug 12, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.14 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.14 MB 0%

@MikesGlitch MikesGlitch marked this pull request as ready for review August 12, 2024 19:34
@MikesGlitch MikesGlitch force-pushed the electron/fix-export-on-mac branch from 57e6751 to a9b73fb Compare August 12, 2024 21:53
Copy link
Contributor

@matt-fidd matt-fidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on the video (and seems like a reasonable change), might want an approval from someone with an affected mac too.

@MikesGlitch
Copy link
Contributor Author

Approved based on the video (and seems like a reasonable change), might want an approval from someone with an affected mac too.

I tested on my mac VM - works a treat!

@MikesGlitch MikesGlitch merged commit 89b096a into actualbudget:master Aug 14, 2024
19 checks passed
@MikesGlitch MikesGlitch deleted the electron/fix-export-on-mac branch August 14, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Desktop Client no longer able to export budget files
2 participants