Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Revert ":electron: Update Electron to latest stable version (#2763)" #2845

Closed
wants to merge 1 commit into from

Conversation

MatissJanis
Copy link
Member

This reverts commit 2901b5e.

Just checking if reverting this PR would fix #2705

@github-actions github-actions bot changed the title Revert ":electron: Update Electron to latest stable version (#2763)" [WIP] Revert ":electron: Update Electron to latest stable version (#2763)" Jun 5, 2024
Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit a5078ba
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6660d0fbbcab2f00084e2795
😎 Deploy Preview https://deploy-preview-2845.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trafico-bot trafico-bot bot added 🚧 WIP and removed 🚧 WIP labels Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.74 MB → 4.74 MB (+1 B) +0.00%
Changeset
File Δ Size
package.json 📈 +1 B (+0.03%) 2.87 kB → 2.88 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 3.01 MB → 3.01 MB (+1 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 75.5 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.41 kB 0%
static/js/wide.js 263.37 kB 0%
static/js/ReportRouter.js 1.23 MB 0%

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@MatissJanis
Copy link
Member Author

Nope, this is not the problem.

@MatissJanis MatissJanis closed this Jun 5, 2024
@MatissJanis MatissJanis deleted the matiss/revert-electron-upgrade branch June 5, 2024 21:04
@youngcw
Copy link
Member

youngcw commented Jun 5, 2024

I believe that was the only change to electron this last month. My next guess would be that there is something happening with the GH Mac runner.

@MatissJanis
Copy link
Member Author

That's a good idea. The build here is working OK: https://github.com/actualbudget/actual/actions/runs/8971187425

I'll re-run the job and see if the new build breaks.

@MatissJanis
Copy link
Member Author

The new build breaks! You're on to something @youngcw !

https://github.com/actualbudget/actual/actions/runs/8971187425

--

Lets move the discussion back to #2705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Desktop app on macOS budget loading error
2 participants