-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Revert ":electron: Update Electron to latest stable version (#2763)" #2845
Conversation
This reverts commit 2901b5e.
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Nope, this is not the problem. |
I believe that was the only change to electron this last month. My next guess would be that there is something happening with the GH Mac runner. |
That's a good idea. The build here is working OK: https://github.com/actualbudget/actual/actions/runs/8971187425 I'll re-run the job and see if the new build breaks. |
The new build breaks! You're on to something @youngcw ! https://github.com/actualbudget/actual/actions/runs/8971187425 -- Lets move the discussion back to #2705 |
This reverts commit 2901b5e.
Just checking if reverting this PR would fix #2705