Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: macos testing #1905

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −7
Draft

WIP: macos testing #1905

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f6ac63
try running unit tests under macos-latest
bdehamer Dec 13, 2024
1ddbb21
try to sysdiagnose
bdehamer Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ jobs:

strategy:
matrix:
runs-on: [ubuntu-latest, macos-latest-large, windows-latest]
runs-on: [macos-latest]

# Node 18 is the current default Node version in hosted runners, so users may still use the toolkit with it when running tests (see https://github.com/actions/toolkit/issues/1841)
# Node 20 is the currently support Node version for actions - https://docs.github.com/actions/sharing-automations/creating-actions/metadata-syntax-for-github-actions#runsusing-for-javascript-actions
node-version: [18.x, 20.x]
node-version: [20.x]
fail-fast: false

runs-on: ${{ matrix.runs-on }}
Expand All @@ -44,12 +44,18 @@ jobs:
run: npm run build

- name: npm test
run: npm test -- --runInBand --forceExit
env:
GITHUB_TOKEN: ${{ github.token }}
run: |
npx jest --testPathPattern packages/exec/__tests__/exec.test.ts -t "Handles child process holding streams open"

- name: Lint
run: npm run lint
- name: sysdiagnose
if: ${{ failure() }}
run: |
sudo sysdiagnose -u -f ${RUNNER_TEMP} -A sysdiagnose.tar.gz

- name: Format
run: npm run format-check
- uses: actions/upload-artifact@v4
if: ${{ failure() }}
with:
name: sysdiagnose
path: /Users/runner/work/_temp/sysdiagnose.tar.gz
Loading