Fix the job summary table example #1892
Open
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the example of adding a table to a job summary using core.summary.addTable() to be correct. It also changes the data row to use strings instead of objects to show both ways that cell data can be defined. This mirrors the job summary announcement blog post.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current example for using
core.summary.addTable()shows passing the data as a single row and does not correctly represent the sample output. This updates the example to be accurate both in code and in example output. I also took the liberty of changing the data cell content to strings to show both ways of passing cell data. This mirrors the blog post that announced job summaries.