BC: Do not run stale logic for newly stale objects #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:97 ::group::[actions#2] Issue actions#2 [actions#2] Issue actions#2 [actions#2] Found this issue last updated at: 2023-08-09T14:33:12Z ... [actions#2] Marking this issue as stale [actions#2] This issue is now stale [actions#2] This issue is already stale At this point, things are already pretty bad. The issue wasn't _already_ stale, it was _just marked_ stale. There was a lot of code trying to keep this state in mind, and it yields some really lousy outcomes... [actions#2] Checking for label on this issue [actions#2] Issue marked stale on: 2023-08-11T03:11:21Z [actions#2] Checking for comments on issue since: 2023-08-11T03:11:21Z Great, so, while the workflow is running, it's looking to see if any new comments have arrived since the workflow itself marked the issue as stale. The odds of there being any are very close to 0, and really there's no point in checking now, it makes much more sense to check the _next_ time the workflow runs. [actions#2] Comments that are not the stale comment or another bot: 0 [actions#2] Issue has been commented on: false [actions#2] Days before issue close: 3 [actions#2] The option remove-stale-when-updated (https://github.com/actions/stale#remove-stale-when-updated) is: true [actions#2] The stale label should not be removed [actions#2] marked stale this run, so don't check for updates Here we finally think about the fact that we're in this edge case. The only thing that makes sense to keep, and which is moved by this change is: [actions#2] Removing all the labels specified via the labels-to-remove-when-stale (https://github.com/actions/stale#labels-to-remove-when-stale) option. [actions#2] Removing the label "label-to-add-when-unstale" from this issue... Error: [actions#2] Error when removing the label: "Label does not exist" We return to nonsensical tasks: [actions#2] Issue has been updated since it was marked stale: false [actions#2] Issue has been updated in the last 3 days: true [actions#2] Stale issue is not old enough to close yet (hasComments? false, hasUpdate? true) Note that it's a really rude behavior to mark an item as stale and close it in the same action. BEHAVIOR CHANGE: This change will force action users to trigger two workflow runs if they want to retain that rude behavior. [actions#2] 5 operations consumed for this issue ::endgroup::
|
Hello @jsoref , thank you for the PR, it seems to be reasonable, we need some time to investigate it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Simplify code for handling the transition from not-stale to stale. Do not run lots of code that makes no sense during this transition.
https://github.com/jsoref/stale-bot-debug/actions/runs/5828506506/job/15806335430#step:2:97
BEHAVIOR CHANGE:
This change will force action users to trigger two action runs if they want to both mark an item as stale and close it.
(You could technically write a workflow that called the action twice, it doesn't actually require two workflows.)
Related issue:
Add link to the related issue.
Check list: