Add JSON output of go env and some env as strings

[lucacome]

Description:
Additional outputs are:

• GOPATH as go-path string
  - GOROOT as go-root string
• GOMOD as go-mod string
• GOCACHE as go-cache string
• GOMODCACHE as go-mod-cache string
• go env as go-env JSON

Related issue:
Closes #54

Check list:

• Mark if documentation changes are required.
• Mark if tests were added or updated to cover the changes.

[lucacome]

@marko-zivic-93 could you approve the CI run again? 🙏

[lucacome]

Not really sure why it failed basic validation on windows...maybe a flaky test?

[mvdan]

action.yml appears to be missing go-cache, FYI. It would be nice to include all the other values from go env as well. For example, GOOS, GOARCH, GOPROXY, and GOAMD64 may be useful. We could carefully maintain a list of which ones are interesting or useful, but I would personally just expose all 39 of them. I imagine we could auto-generate the list to include in action.yaml.

I'm also thinking that it would be nicest if we could use the exact same names that go env uses. Otherwise I have to remind myself how each one of them was transformed, because there's a rather arbitrary choice about where the dashes are inserted. For example, would GOSUMDB be go-sumdb or go-sum-db? Some of its names, like CGO_ENABLED, already use underscores as well - so either cgo-enabled or cgo_enabled would be weird.

I would personally expose each one of them as-is, uppercase and all, like steps.setup-go.outputs.GOCACHE. Or, if we want them to have a common prefix to clarify that they come from go env, perhaps steps.setup-go.outputs.env_GOCACHE, though I don't think it's necessary. The fact that they are uppercase should be enough of a signal.

[lucacome]

Thanks for catching that @mvdan I've added go-cache to action.yml.

As for the naming, I was using the same pattern used in the other variables, but I'm happy to change them if people think that's a better approach. As for exposing all of them, I didn't want to pollute the outputs and I'm not sure how we could auto-generate them... 😅

Some guidance from the maintainers would be appreciated 🙏

[lucacome]

is there anything I can do to get this PR reviewed?

[mvdan]

cc @dmitry-shibanov :)

[Erictorrm]

Duplicate of #

[dsame]

Hello @lucacome

Can you please remove the most outputs except these 3 ones

    core.setOutput('go-version', parsedGoVersion);
    core.setOutput('go-cache', goEnvJson['GOCACHE']);
    core.setOutput('go-mod-cache', goEnvJson['GOMODCACHE']);

The others does not seem relate to any real-world use cases.

[lucacome]

Hi @dsame

I'm personally interested in go-path so I would like to keep that one as well 😅
Are you saying to also remove core.setOutput('go-env', goEnvJson); ?

[mvdan]

I'm still of the opinion that the entire go env -json should be exposed in its entirety - I find most of the vars useful.

[lucacome]

What needs to be done to get this merged?