Clarify syntax for githubConfigSecret
#3812
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jww3
requested review from
mumoshu,
toast-gear,
rentziass and
a team
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution.
Please review our contribution guidelines to understand the project's testing and code conventions.
yacaovsnc
approved these changes
Nov 22, 2024
corycalahan
reviewed
Nov 22, 2024
| @@ -2,25 +2,40 @@ | |||
| ## ex: https://github.com/myorg/myrepo or https://github.com/myorg | |||
There was a problem hiding this comment.
Are there any specific configuration setting(s) that could also be supplied as examples when Authenticating ARC with a personal access token (classic) that could be possible clarifying text for "githubConfigUrl: """?
## githubConfigUrl is the GitHub url for where you want to configure runners
## ex: https://github.com/myorg/myrepo or https://github.com/myorg
githubConfigUrl: ""e.g. if yes, what is the string format?
https://github.com/enterprises/myenterprise
?
Link-
modified the milestones:
gha-runner-scale-set-0.10.0,
gha-runner-scale-set-0.10.1,
gha-runner-scale-set-0.10.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've received several reports from customers that the embedded documentation on
githubConfigSecretis confusing. This PR attempts to add clarity there.