Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): correctly template actionsmetrics service ports #3751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chrisminton
Copy link

@chrisminton chrisminton commented Sep 18, 2024

  • currently setting the service ports via actionsMetricsServer.enabled: true gives:
    Warning  UpgradeFailed  2s  helm-controller  Helm upgrade failed for release namespace/actions-runner-controller with chart [email protected]: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:
    line 19: mapping key "name" already defined at line 15
    line 20: mapping key "port" already defined at line 16
    line 21: mapping key "protocol" already defined at line 17
    line 22: mapping key "targetPort" already defined at line 18
    

since the values.yaml already provides the key/values for the ports, just use toYaml which does correctly template the values. This change outputs (with the default values):

spec:
  type: ClusterIP
  ports:
    - name: http
      port: 80
      protocol: TCP
      targetPort: http

@Link- Link- self-assigned this Dec 4, 2024
@Link- Link- added the attention Requires attention label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention Requires attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants