Remove params.pp in favor of Hiera v5 lookups

[jorhett]

Separate v1/v2 defaults into separate files

Create two new exposed variables for rule managements to use:

• cis_benchmarks::script_dir: The resolved script directory, to avoid different resolutions
• cis_benchmarks::cis_version_base: Where to find data for a given OS and cis version combination

These changes should greatly simplify adding EL6 and CIS v2.2 support
Fixes: #6 #8 #9

[abuxton]

Hi, the params.pp pattern is used in this context as it is in use on servers that have no support for hiera v5.
The module supported version supports hierav4, and use of params gives support for hiera 3+ and ignores hiera.yaml.

to make this change woudl be a major version bump, to do that I would like to refactor the facter facts to be deployed with /facts.d mechanism in all cases but the rpm validation fact

I would still keep the params.pp pattern as it is not reuire dto override the data in hiera in any way if you enforce the module in strict mode and as such it should simply use clear, visible and self-contained data

A new version of the rules is now available, as such an update is needed to support changes.

[jorhett]

So the problem with params.pp is that it creates a crazy mesh of data stored there which is a mixture of the different CIS versions. I am no stranger to Puppet or large modules, and I was constantly flipping back and forth trying to track down where data was coming from.

Moving the data to version-specific Hiera files greatly simplifies that.

[abuxton]

ok, i'm going to finally send this thank you for the patience