Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): Port to Alloy #250

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Aug 13, 2024

Description

Ports the config module to use alloy-primitives types instead of ethers types.

This is part 1 of the great alloy migration.

@refcell refcell added K-chore Kind: general fixes not relating to a bug M-port Meta: Ports code to new implementations A-config Area: Magi configuration changes labels Aug 13, 2024
@refcell refcell requested a review from ncitron August 13, 2024 22:27
@refcell refcell self-assigned this Aug 13, 2024
@wiz-a16z
Copy link

wiz-a16z bot commented Aug 13, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 1H 0M 0L 6I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 1H 0M 0L 6I
Secrets 0🔑

@refcell refcell changed the title fix(config): Alloy Port chore(config): Port to Alloy Aug 13, 2024
@ncitron
Copy link
Contributor

ncitron commented Aug 13, 2024

How is this related to the work you've already done in the alloy branch?

Copy link
Contributor

@ncitron ncitron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncitron ncitron merged commit 922e6a2 into master Aug 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-config Area: Magi configuration changes K-chore Kind: general fixes not relating to a bug M-port Meta: Ports code to new implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants