This repository has been archived by the owner on May 16, 2022. It is now read-only.
FIX : datepicker date format for other locale used #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add the compatibility with requireJS
---- FIXES ----
1 - Date format
Before the fix, if the user locale is, for example, the french locale, the date format returned is dd/mm/yy instead of yy-mm-dd. If the user click on the 13th of December, the date won't be recognised by moment.
Now, the datepicker always returns a yy-mm-dd formatted date value.
2 - Dragging not allowed
Even is allowDragging option was set to false, it called the draggable jquery-ui fonction to destroy some element during the initialization.
I surrounded this call so that it is done only if the allowDragging option is enabled
Moreover, if jquery-ui is not included because not needed, it will also work.