[autopatch] Automatic patch attempt for helpers 2.1 #193
Conversation
|
!testme |
|
!testme |
|
Living in the future, are we? |
|
Alrighty! |
| domain=$new_domain | ||
| path=$new_path | ||
| ynh_add_config --template="../conf/config.ini" --destination="$install_dir/config.ini" | ||
| ynh_config_add --template="config.ini" --destination="$install_dir/config.ini" |
There was a problem hiding this comment.
Looks weird, that needs testing
|
|
||
| chmod 400 "$install_dir/config.ini" | ||
| chown $app:$app "$install_dir/config.ini" | ||
| ynh_config_add --template="config.ini" --destination="$install_dir/config.ini" |
There was a problem hiding this comment.
Same warning about config.ini path
There was a problem hiding this comment.
#REMOVEME? Assuming the file is setup using ynh_config_add, the proper chmod/chowns are now already applied and it shouldn't be necessary to tweak perms | chmod 400 "$install_dir/config.ini"
chmod 400
chown $app:
should be applied by the helper 2.1. If the app is writing to the config file then chmod 600 should be added to the script...
There was a problem hiding this comment.
My warning was regarding the config.ini filepath (moving from ../config.ini to config.ini).
There was a problem hiding this comment.
you mean from --template="../conf/config.ini" to --template="config.ini"?
There was a problem hiding this comment.
../conf/ path is implied, therefore so no need to put the full path
This is an automatic PR
This is an automated patch for the switch to helpers 2.1
If you are not familar with helpers 2.1, please check the discussion at https://forum.yunohost.org/t/new-experimental-2-1-helpers/30114
Please bear in mind that this is just an automated patch and it is very likely to not work out of the box.
In particular it is known to possibly create syntax issues or permission issues which may need to be resolved manually. You are absolutely encouraged to come discuss about this on the app packaging room if you are unsure how to fix a specific issue.