Add navigation block #443
Merged
Add navigation block #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
added
[Block] New Block
Redesign
adamwoodnz
commented
Sep 6, 2023
Copied from wporg-main-2022 for reuse
adamwoodnz
force-pushed
the
add/442-navigation-block
branch
from
e88836b to
8f03c79
Compare
adamwoodnz
commented
Sep 6, 2023
adamwoodnz
commented
Sep 6, 2023
| * `wp_json_file_decode` & `register_block_script_handle. | ||
| */ | ||
| function init() { | ||
| $metadata_file = dirname( dirname( __DIR__ ) ) . '/blocks/navigation/build/block.json'; |
There was a problem hiding this comment.
Path changed from main due to different file structure
This was referenced Sep 6, 2023
adamwoodnz
force-pushed
the
add/442-navigation-block
branch
from
990ca72 to
14a0e95
Compare
adamwoodnz
force-pushed
the
add/442-navigation-block
branch
from
14a0e95 to
9b73837
Compare
adamwoodnz
commented
Sep 7, 2023
| 'enqueue_block_assets', | ||
| function() use ( $editor_script_handle ) { | ||
| if ( is_admin() && wp_should_load_block_editor_scripts_and_styles() ) { | ||
| wp_localize_script( |
There was a problem hiding this comment.
Pass menus to block editor frontend
ryelle
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
Working great! I tested with both WordPress/wporg-documentation-2022#67 & WordPress/wporg-main-2022#323, and the frontend display works + editor UI looks good too.
A few minor comments, but nothing blocking 👍🏻
Co-authored-by: Kelly Dwan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #442
Copies the navigation block from wporg-main-2022 for reuse, and adds config for the documentation menu.
Testing