Theme: Add a stylesheet to be used for rosetta site overrides #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some locales have translated this which generates warnings. The warnings are good, but the translators themselves are highly unlikely to ever see them (since they only appear in dev environments).
adamwoodnz
reviewed
Jan 15, 2024
source/wp-content/themes/wporg-main-2022/src/rosetta/style.scss
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Wood <[email protected]>
adamwoodnz
reviewed
Jan 16, 2024
| @@ -95,6 +99,15 @@ function enqueue_assets() { | |||
| global_fonts_preload( 'EB Garamond italic', $subsets ); | |||
| } | |||
| } | |||
|
|
|||
| if ( is_rosetta_site() ) { | |||
There was a problem hiding this comment.
This is always false for me locally, I set it to true to test and the styles work
There was a problem hiding this comment.
Makes sense, I think I was working solely on my sandbox when I got to this part of the work. As a follow up, I'll see about adding a locale check to is_rosetta_site here to make it work locally.
adamwoodnz
reviewed
Jan 16, 2024
source/wp-content/themes/wporg-main-2022/src/rosetta/style.scss
Outdated
Show resolved
Hide resolved
adamwoodnz
approved these changes
Jan 16, 2024
Co-authored-by: Adam Wood <[email protected]>
ryelle
added a commit
that referenced
this pull request
Jan 18, 2024
This enables the stylesheet to be loaded on a local environment by switching the test site's locale. See #380 (comment)
BreadGuy007
added a commit
to BreadGuy007/WP_org
that referenced
this pull request
Apr 15, 2024
This enables the stylesheet to be loaded on a local environment by switching the test site's locale. See WordPress/wporg-main-2022#380 (comment)
adamwoodnz
added a commit
that referenced
this pull request
May 23, 2024
Hyphenation was added to fix https://meta.trac.wordpress.org/ticket/7398, but we have a better way of handling resizing fonts for rosetta sites now, see #380 Fixes #442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a place for polyglots teams to add page & section-specific overrides for their sites. Anything more global should go in the parent theme, see the related PR: WordPress/wporg-parent-2021#120.
Specifically in this PR, I've added some code to shrink the headings on the About page, as they're defined in the CSS, not theme.json settings.
See #266, WordPress/wporg-parent-2021#120.
Screenshots
How to test the changes in this Pull Request:
You can test localized sites by following the instructions on wporg-main-2022.
I also tested this on my sandbox with the top completed languages for wporg.