Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use chevron icon for local nav mobile menus #335

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Use chevron icon for local nav mobile menus #335

merged 1 commit into from
Oct 18, 2023

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Oct 18, 2023 •
edited
Loading

Closes #334
Depends on WordPress/wporg-mu-plugins#480

Changes the local navigation blocks to use the 'menu' (3 bar) icon on mobile, so that in conjunction with WordPress/wporg-mu-plugins#480 the button changes from the word 'Menu' to a chevron icon.

Screenshots

Page:State Before After
About:Closed localhost_8888_about_domains_(Samsung Galaxy S20 Ultra) localhost_8888_about_domains_(Samsung Galaxy S20 Ultra) (2)
About:Open localhost_8888_about_domains_(Samsung Galaxy S20 Ultra) (1) localhost_8888_about_domains_(Samsung Galaxy S20 Ultra) (3)
Counter:Closed localhost_8888_download_counter_(Samsung Galaxy S20 Ultra) localhost_8888_download_counter_(Samsung Galaxy S20 Ultra) (2)
Counter:Open localhost_8888_download_counter_(Samsung Galaxy S20 Ultra) (1) localhost_8888_download_counter_(Samsung Galaxy S20 Ultra) (3)

How to test the changes in this Pull Request:

  1. Unsure your mu-plugins is on Add filter to replace local nav bar mobile menu icon wporg-mu-plugins#480
  2. Open a page from each About sub section, eg. requirements, domains, and philosophy, plus the download counter
  3. Simulate mobile screen size
  4. Check that the icon in the mobile menu button is a chevron
  5. Open the menu
  6. Check the the chevron icon has been flipper vertically
  7. Close the menu

@adamwoodnz adamwoodnz self-assigned this Oct 18, 2023
@adamwoodnz adamwoodnz force-pushed the update/481-local-nav-use-chevron-icon branch from 029039d to 11b3e47 Compare October 18, 2023 03:07
@adamwoodnz adamwoodnz marked this pull request as ready for review October 18, 2023 03:26
@adamwoodnz adamwoodnz requested review from StevenDufresne, marko-srb, a team and renintw and removed request for marko-srb October 18, 2023 03:26
@adamwoodnz adamwoodnz added the [Component] Theme Templates, patterns, CSS label Oct 18, 2023
@jasmussen
Copy link
Contributor

Change looks good!

@adamwoodnz adamwoodnz merged commit 444272d into trunk Oct 18, 2023
2 checks passed
@adamwoodnz adamwoodnz deleted the update/481-local-nav-use-chevron-icon branch October 18, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenDufresne StevenDufresne Awaiting requested review from StevenDufresne

@renintw renintw Awaiting requested review from renintw

Assignees

@adamwoodnz adamwoodnz

Labels
[Component] Theme Templates, patterns, CSS
Projects
@adamwoodnz's WIP
Status: Done
WordPress.org
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use chevron icon for local nav menus
2 participants
@adamwoodnz @jasmussen