Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This diff removes the arrow icon from the WordPress admin menu. Let'… #8016

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

pbearne
Copy link

@pbearne pbearne commented Dec 17, 2024

…s break down the changes:

  • src/wp-admin/menu-header.php: The primary change is the removal of the $arrow variable and its inclusion in the menu item's HTML. Every instance of $arrow within the <a> tag has been deleted. This directly removes the arrow element from the rendered output.

  • src/wp-admin/css/admin-menu.css: The CSS changes further support the removal of the arrow. The rules related to .wp-menu-arrow are removed. Specifically:

    • #adminmenu li.wp-has-current-submenu a.wp-has-current-submenu, #adminmenu li.current a.menu-top, #adminmenu .wp-menu-arrow, #adminmenu .wp-has-current-submenu .wp-submenu .wp-submenu-head, #adminmenu .wp-menu-arrow div is changed to remove .wp-menu-arrow and .wp-menu-arrow div. This removes styling for the arrow itself and for parent menu items.
    • The /* A new arrow */ comment block and the following .wp-menu-arrow style block, which hid the arrow (display: none !important;), is completely deleted. Since the arrow element is no longer present in the HTML, these styles are unnecessary.

In summary, these changes effectively delete the arrow that typically appears next to WordPress admin menu items that have submenus. The HTML generating the arrow is removed, and the corresponding CSS styling is deleted. This results in a cleaner, more minimalist look for the admin menu.

Trac ticket: https://core.trac.wordpress.org/ticket/26960

… break down the changes:

* **`src/wp-admin/menu-header.php`**:  The primary change is the removal of the  `$arrow` variable and its inclusion in the menu item's HTML.  Every instance of `$arrow` within the `<a>` tag has been deleted.  This directly removes the arrow element from the rendered output.

* **`src/wp-admin/css/admin-menu.css`**:  The CSS changes further support the removal of the arrow.  The rules related to `.wp-menu-arrow` are removed.  Specifically:
    *  `#adminmenu li.wp-has-current-submenu a.wp-has-current-submenu, #adminmenu li.current a.menu-top, #adminmenu .wp-menu-arrow, #adminmenu .wp-has-current-submenu .wp-submenu .wp-submenu-head, #adminmenu .wp-menu-arrow div` is changed to remove `.wp-menu-arrow` and `.wp-menu-arrow div`. This removes styling for the arrow itself and for parent menu items.
    *  The `/* A new arrow */` comment block and the following `.wp-menu-arrow` style block, which hid the arrow (`display: none !important;`), is completely deleted.  Since the arrow element is no longer present in the HTML, these styles are unnecessary.

In summary, these changes effectively delete the arrow that typically appears next to WordPress admin menu items that have submenus.  The HTML generating the arrow is removed, and the corresponding CSS styling is deleted. This results in a cleaner, more minimalist look for the admin menu.
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @[email protected].

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant